Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add option to display tooltip on link hover #8394

Merged
merged 37 commits into from
Jul 6, 2022
Merged

Add option to display tooltip on link hover #8394

merged 37 commits into from
Jul 6, 2022

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Apr 22, 2022 •
edited by github-actions bot
Loading

This makes it possible for platforms like Electron apps, which lack a built-in URL preview in the status bar, to enable tooltip previews of links.

Screenshot 2022-04-22 at 20 46 52

This will require a corresponding change in element-web to override needsUrlTooltips in ElectronPlatform. For testing in a browser, you can change the default value in BasePlatform.

One problem I wasn't able to fix yet is that when clicking a link and returning, the tooltip persists. Disabling the tooltip on focus fixes this but probably breaks accessibility. Curious if anyone has ideas on what to do here.

For element-hq/element-web#22286
Relates to element-hq/element-web#6532
Closes element-hq/element-web#21907

Here's what your changelog entry will look like:

✨ Features

Preview: https://pr8394--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@Johennes
Add option to display tooltip on link hover
f18cce8 
This makes it possible for platforms like Electron apps, which lack
a built-in URL preview in the status bar, to enable tooltip previews
of links.

Relates to: element-hq/element-web#6532
Signed-off-by: Johannes Marbach <[email protected]>
@Johennes Johennes requested a review from a team as a code owner April 22, 2022 18:55
@Johennes Johennes marked this pull request as draft April 22, 2022 18:55
@codecov
Copy link

codecov bot commented Apr 22, 2022 •
edited
Loading

Codecov Report

Merging #8394 (cf07f54) into develop (bb4064f) will decrease coverage by 0.00%.
The diff coverage is 19.35%.

❗ Current head cf07f54 differs from pull request most recent head f90805f. Consider uploading reports for the commit f90805f to get more accurate results

@@             Coverage Diff             @@
##           develop    #8394      +/-   ##
===========================================
- Coverage    30.78%   30.77%   -0.01%     
===========================================
  Files          892      892              
  Lines        50664    50695      +31     
  Branches     12892    12898       +6     
===========================================
+ Hits         15595    15601       +6     
- Misses       35069    35094      +25
Impacted Files Coverage Δ
src/BasePlatform.ts 6.13% <0.00%> (-0.08%) ⬇️
...c/components/views/messages/EditHistoryMessage.tsx 0.00% <0.00%> (ø)
src/HtmlUtils.tsx 37.10% <21.73%> (-1.52%) ⬇️
src/components/views/messages/TextualBody.tsx 57.44% <100.00%> (+0.15%) ⬆️

@Johennes Johennes marked this pull request as ready for review April 22, 2022 19:27
@robintown robintown added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Apr 24, 2022
@dbkr dbkr requested a review from janogarcia April 25, 2022 12:22
turt2live
turt2live reviewed May 2, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally seems fine - thanks for the change :)

src/BasePlatform.ts Outdated Show resolved Hide resolved
src/HtmlUtils.tsx Outdated Show resolved Hide resolved
src/HtmlUtils.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to Netlify May 2, 2022 18:25 Destroyed
@github-actions github-actions bot temporarily deployed to Netlify May 2, 2022 18:32 Destroyed
@github-actions github-actions bot temporarily deployed to Netlify May 2, 2022 18:39 Destroyed
@Johennes Johennes requested a review from turt2live May 2, 2022 18:42
turt2live
turt2live approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

src/HtmlUtils.tsx Outdated Show resolved Hide resolved
t3chguy
t3chguy reviewed May 6, 2022
View reviewed changes
src/HtmlUtils.tsx Outdated Show resolved Hide resolved
@janogarcia
Copy link
Contributor

Thanks, @Johennes!

Just a few issues I spotted when testing it.

Unsure if these are related in any way on how I enabled the URL tooltips in your Netlify build (ran mxPlatformPeg.get().needsUrlTooltips = () => true; instead of tweaking BasePlatform as suggested by @t3chguy cause otherwise monkey-patching the platform object would only affect linkification after that command).

  • Links in the message body: At least on Chrome macOS the keyboard focus is trapped three times for each link. First time it doesn't show the tooltip, second and third tab press shows the tooltip. That said, some links only trap the focus twice, unsure what made those few links behave differently.
  • Link in the URL preview title .mx_LinkPreviewWidget: Those links that show a tooltip trap the keyboard focus twice and don't show the tooltip the first time the link gets the keyboard focus. Other links only only trap the keyboard focus once but don't show the tooltip.

As for the tooltip not being automatically dismissed on visiting a link, I'd suggest either trying to dismiss it (ideal scenario) or just keep it as is, but not disabling it for keyboard navigation otherwise we could just use the title attribute which would have similar accessibility limitations.

https://www.tpgi.com/using-the-html-title-attribute/

janogarcia
janogarcia reviewed May 9, 2022
View reviewed changes
Copy link
Contributor

@janogarcia janogarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR comments in my previous message. #8394 (comment)

@janogarcia
Copy link
Contributor

Keyboard navigation:

tooltips

@MadLittleMods MadLittleMods removed the Z-Community-PR Issue is solved by a community member's PR label Jun 1, 2022
@Johennes
Copy link
Contributor Author

Johennes commented Jun 2, 2022

I just noticed that the titles in URL preview titles (.mx_LinkPreviewWidget) don't generate a tooltip anymore. Is that expected?

Ah, great catch @janogarcia! I think these may have worked by accident only in the earlier version due to the same bug that caused the multifold keyboard trap. I've explicitly made them work in the fixed version as well now.

@t3chguy sorry, could I ask you for another review on the small change in the last commit?

@Johennes Johennes requested a review from t3chguy June 2, 2022 19:01
@Johennes Johennes requested a review from janogarcia June 27, 2022 18:23
@Johennes
Copy link
Contributor Author

@janogarcia could you give this another look?

@janogarcia
Copy link
Contributor

janogarcia commented Jul 5, 2022 •
edited
Loading

@Johennes Just tested it. Now it seems I'm only getting tooltips for the links in URL previews but not for text links in the message body . mx_EventTile_body. Unsure if that's a regression or a side-effect of the way I'm enabling tooltips on the Netlify build.

@Johennes
Copy link
Contributor Author

Johennes commented Jul 5, 2022

@Johennes Just tested it. Now it seems I'm only getting tooltips for the links in URL previews but not for text links in the message body . mx_EventTile_body. Unsure if that's a regression or a side-effect of the way I'm enabling tooltips on the Netlify build.

@janogarcia: Hm, I just merged in master and tested again but it still works in both cases for me.

Screenshot 2022-07-05 at 21 43 36
Screenshot 2022-07-05 at 21 43 43

One thing to note is that the tooltip will not be shown if the link text is identical to the URL. E.g. the https://smartmobilefactory.com link in the screenshots above does not show a tooltip because that would just show the same text again.

Is it possible you've run into this case?

@janogarcia
Copy link
Contributor

Is it possible you've run into this case?

Actually, I tested it for text links (rather than plain URLs) where the text link differs from the actual link, as I was aware of that behavior. I still think it may be related to how I enabled the feature via the browser console.

@janogarcia
Copy link
Contributor

@Johennes It seems to be related to that console script, indeed. The correct behavior will only be attached to those links created after running the script. So, that's why it wasn't working for old messages for me.

tooltips

@janogarcia
Copy link
Contributor

@Johennes I'm approving the changes, assuming that when correctly enabled it will attach the tooltip behavior to all links (past and new). 👍 Thanks for working on this!

@Johennes
Copy link
Contributor Author

Johennes commented Jul 6, 2022

Thanks @janogarcia! 🙂

@t3chguy if you're d'accord this should be ready to merge then, I think.

@t3chguy t3chguy enabled auto-merge (squash) July 6, 2022 09:26
@t3chguy t3chguy merged commit 6f21a15 into matrix-org:develop Jul 6, 2022
@turt2live turt2live mentioned this pull request Jul 18, 2022
Closed
@Johennes Johennes mentioned this pull request Jul 22, 2022
Merged
3 tasks
su-ex added a commit to SchildiChat/element-desktop that referenced this pull request Aug 1, 2022
@su-ex
Merge tag 'v1.11.1' into sc
e65c31b 
* Enable URL tooltips on hover for Element Desktop ([\#22286](element-hq/element-web#22286)). Fixes undefined/element-web#6532.
* Hide screenshare button in video rooms on Desktop ([\#9045](matrix-org/matrix-react-sdk#9045)).
* Add a developer command to reset Megolm and Olm sessions ([\#9044](matrix-org/matrix-react-sdk#9044)).
* add spaces to TileErrorBoundary ([\#9012](matrix-org/matrix-react-sdk#9012)). Contributed by @HarHarLinks.
* Location sharing - add localised strings to map ([\#9025](matrix-org/matrix-react-sdk#9025)). Fixes element-hq/element-web#21443. Contributed by @kerryarchibald.
* Added trim to ignore whitespaces in email check ([\#9027](matrix-org/matrix-react-sdk#9027)). Contributed by @ankur12-1610.
* Improve _GenericEventListSummary.scss ([\#9005](matrix-org/matrix-react-sdk#9005)). Contributed by @luixxiul.
* Live location share - tiles without tile server (PSG-591) ([\#8962](matrix-org/matrix-react-sdk#8962)). Contributed by @kerryarchibald.
* Add option to display tooltip on link hover ([\#8394](matrix-org/matrix-react-sdk#8394)). Fixes element-hq/element-web#21907.
* Support a module API surface for custom functionality ([\#8246](matrix-org/matrix-react-sdk#8246)).
* Adjust encryption copy when creating a video room ([\#8989](matrix-org/matrix-react-sdk#8989)). Fixes element-hq/element-web#22737.
* Add bidirectonal isolation for pills ([\#8985](matrix-org/matrix-react-sdk#8985)). Contributed by @sha-265.
* Delabs `Show current avatar and name for users in message history` ([\#8764](matrix-org/matrix-react-sdk#8764)). Fixes element-hq/element-web#22336.
* Live location share - open latest location in map site ([\#8981](matrix-org/matrix-react-sdk#8981)). Contributed by @kerryarchibald.
* Improve LinkPreviewWidget ([\#8881](matrix-org/matrix-react-sdk#8881)). Fixes element-hq/element-web#22634. Contributed by @luixxiul.
* Render HTML topics in rooms on space home ([\#8939](matrix-org/matrix-react-sdk#8939)).
* Hide timestamp on event tiles being edited on every layout ([\#8956](matrix-org/matrix-react-sdk#8956)). Contributed by @luixxiul.
* Introduce new copy icon ([\#8942](matrix-org/matrix-react-sdk#8942)).
* Allow finding group DMs by members in spotlight ([\#8922](matrix-org/matrix-react-sdk#8922)). Fixes element-hq/element-web#22564. Contributed by @justjanne.
* Live location share - explicitly stop beacons replaced beacons ([\#8933](matrix-org/matrix-react-sdk#8933)). Contributed by @kerryarchibald.
* Remove unpin from widget kebab menu ([\#8924](matrix-org/matrix-react-sdk#8924)).
* Live location share - redact related locations on beacon redaction ([\#8926](matrix-org/matrix-react-sdk#8926)). Contributed by @kerryarchibald.
* Live location share - disallow message pinning ([\#8928](matrix-org/matrix-react-sdk#8928)). Contributed by @kerryarchibald.
* Fix manual update checks not working after being dismissed ([\element-hq#388](element-hq#388)). Fixes element-hq/element-web#22795.
* Don't check for updates if we already have one downloaded and queued ([\element-hq#386](element-hq#386)).
* Fix default file name in save-image-as ([\element-hq#385](element-hq#385)). Fixes element-hq/element-web#20838.
* Remove the ability to hide yourself in video rooms ([\#22806](element-hq/element-web#22806)). Fixes element-hq/element-web#22805.
* Unbreak in-app permalink tooltips  ([\#9100](matrix-org/matrix-react-sdk#9100)).
* Add space for the stroke on message editor on IRC layout ([\#9030](matrix-org/matrix-react-sdk#9030)). Fixes element-hq/element-web#22785. Contributed by @luixxiul.
* Fix pinned messages not re-linkifying on edit ([\#9042](matrix-org/matrix-react-sdk#9042)). Fixes element-hq/element-web#22726.
* Don't unnecessarily persist the host signup dialog ([\#9043](matrix-org/matrix-react-sdk#9043)). Fixes element-hq/element-web#22778.
* Fix URL previews causing messages to become unrenderable ([\#9028](matrix-org/matrix-react-sdk#9028)). Fixes element-hq/element-web#22766.
* Fix event list summaries including invalid events ([\#9041](matrix-org/matrix-react-sdk#9041)). Fixes element-hq/element-web#22790.
* Correct accessibility labels for unread rooms in spotlight ([\#9003](matrix-org/matrix-react-sdk#9003)). Contributed by @justjanne.
* Enable search strings highlight on bubble layout ([\#9032](matrix-org/matrix-react-sdk#9032)). Fixes element-hq/element-web#22786. Contributed by @luixxiul.
* Unbreak URL preview for formatted links with tooltips ([\#9022](matrix-org/matrix-react-sdk#9022)). Fixes element-hq/element-web#22764.
* Re-add margin to tiles based on EventTileBubble ([\#9015](matrix-org/matrix-react-sdk#9015)). Fixes element-hq/element-web#22772. Contributed by @luixxiul.
* Fix Shortcut prompt for Search showing in minimized Roomlist ([\#9014](matrix-org/matrix-react-sdk#9014)). Fixes element-hq/element-web#22739. Contributed by @justjanne.
* Fix avatar position on event info line for hidden events on a thread ([\#9019](matrix-org/matrix-react-sdk#9019)). Fixes element-hq/element-web#22777. Contributed by @luixxiul.
* Fix lost padding of event tile info line ([\#9009](matrix-org/matrix-react-sdk#9009)). Fixes element-hq/element-web#22754 and element-hq/element-web#22759. Contributed by @luixxiul.
* Align verification bubble with normal event tiles on IRC layout ([\#9001](matrix-org/matrix-react-sdk#9001)). Fixes element-hq/element-web#22758. Contributed by @luixxiul.
* Ensure timestamp on generic event list summary is not hidden from TimelineCard ([\#9000](matrix-org/matrix-react-sdk#9000)). Fixes element-hq/element-web#22755. Contributed by @luixxiul.
* Fix headings margin on security user settings tab ([\#8826](matrix-org/matrix-react-sdk#8826)). Contributed by @luixxiul.
* Fix timestamp position on file panel ([\#8976](matrix-org/matrix-react-sdk#8976)). Fixes element-hq/element-web#22718. Contributed by @luixxiul.
* Stop using :not() pseudo class for mx_GenericEventListSummary ([\#8944](matrix-org/matrix-react-sdk#8944)). Fixes element-hq/element-web#22602. Contributed by @luixxiul.
* Don't show the same user twice in Spotlight ([\#8978](matrix-org/matrix-react-sdk#8978)). Fixes element-hq/element-web#22697.
* Align the right edge of expand / collapse link buttons of generic event list summary in bubble layout with a variable ([\#8992](matrix-org/matrix-react-sdk#8992)). Fixes element-hq/element-web#22743. Contributed by @luixxiul.
* Display own avatars on search results panel in bubble layout ([\#8990](matrix-org/matrix-react-sdk#8990)). Contributed by @luixxiul.
* Fix text flow of thread summary content on threads list ([\#8991](matrix-org/matrix-react-sdk#8991)). Fixes element-hq/element-web#22738. Contributed by @luixxiul.
* Fix the size of the clickable area of images ([\#8987](matrix-org/matrix-react-sdk#8987)). Fixes element-hq/element-web#22282.
* Fix font size of MessageTimestamp on TimelineCard ([\#8950](matrix-org/matrix-react-sdk#8950)). Contributed by @luixxiul.
* Improve security room settings tab style rules ([\#8844](matrix-org/matrix-react-sdk#8844)). Fixes element-hq/element-web#22575. Contributed by @luixxiul.
* Align E2E icon and avatar of info tile in compact modern layout ([\#8965](matrix-org/matrix-react-sdk#8965)). Fixes element-hq/element-web#22652. Contributed by @luixxiul.
* Fix clickable area of general event list summary toggle ([\#8979](matrix-org/matrix-react-sdk#8979)). Fixes element-hq/element-web#22722. Contributed by @luixxiul.
* Fix resizing room topic ([\#8966](matrix-org/matrix-react-sdk#8966)). Fixes element-hq/element-web#22689.
* Dismiss the search dialogue when starting a DM ([\#8967](matrix-org/matrix-react-sdk#8967)). Fixes element-hq/element-web#22700.
* Fix "greyed out" text style inconsistency on search result panel ([\#8974](matrix-org/matrix-react-sdk#8974)). Contributed by @luixxiul.
* Add top padding to EventTilePreview loader ([\#8977](matrix-org/matrix-react-sdk#8977)). Fixes element-hq/element-web#22719. Contributed by @luixxiul.
* Fix read receipts group position on TimelineCard in compact modern/group layout ([\#8971](matrix-org/matrix-react-sdk#8971)). Fixes element-hq/element-web#22715. Contributed by @luixxiul.
* Fix calls on homeservers without the unstable thirdparty endpoints. ([\#8931](matrix-org/matrix-react-sdk#8931)). Fixes element-hq/element-web#21680. Contributed by @deepbluev7.
* Enable ReplyChain text to be expanded on IRC layout ([\#8959](matrix-org/matrix-react-sdk#8959)). Fixes element-hq/element-web#22709. Contributed by @luixxiul.
* Fix hidden timestamp on message edit history dialog ([\#8955](matrix-org/matrix-react-sdk#8955)). Fixes element-hq/element-web#22701. Contributed by @luixxiul.
* Enable ReplyChain text to be expanded on bubble layout ([\#8958](matrix-org/matrix-react-sdk#8958)). Fixes element-hq/element-web#22709. Contributed by @luixxiul.
* Fix expand/collapse state wrong in metaspaces ([\#8952](matrix-org/matrix-react-sdk#8952)). Fixes element-hq/element-web#22632.
* Location (live) share replies now provide a fallback content ([\#8949](matrix-org/matrix-react-sdk#8949)).
* Fix space settings not opening for script-created spaces ([\#8957](matrix-org/matrix-react-sdk#8957)). Fixes element-hq/element-web#22703.
* Respect `filename` field on `m.file` events ([\#8951](matrix-org/matrix-react-sdk#8951)).
* Fix PlatformSettingsHandler always returning true due to returning a Promise ([\#8954](matrix-org/matrix-react-sdk#8954)). Fixes element-hq/element-web#22616.
* Improve high-contrast support for spotlight ([\#8948](matrix-org/matrix-react-sdk#8948)). Fixes element-hq/element-web#22481. Contributed by @justjanne.
* Fix wrong assertions that all media events have a mimetype ([\#8946](matrix-org/matrix-react-sdk#8946)). Fixes matrix-org/element-web-rageshakes#13727.
* Make invite dialogue fixed height ([\#8934](matrix-org/matrix-react-sdk#8934)). Fixes element-hq/element-web#22659.
* Fix all megolm error reported as unknown ([\#8916](matrix-org/matrix-react-sdk#8916)).
* Remove line-height declarations from _ReplyTile.scss ([\#8932](matrix-org/matrix-react-sdk#8932)). Fixes element-hq/element-web#22687. Contributed by @luixxiul.
* Reduce video rooms log spam ([\#8913](matrix-org/matrix-react-sdk#8913)).
* Correct new search input’s rounded corners ([\#8921](matrix-org/matrix-react-sdk#8921)). Fixes element-hq/element-web#22576. Contributed by @justjanne.
* Align unread notification dot on threads list in compact modern=group layout ([\#8911](matrix-org/matrix-react-sdk#8911)). Fixes element-hq/element-web#22677. Contributed by @luixxiul.
su-ex added a commit to SchildiChat/element-web that referenced this pull request Aug 1, 2022
@su-ex
Merge tag 'v1.11.1' into sc
6655778 
* Enable URL tooltips on hover for Element Desktop ([\element-hq#22286](element-hq#22286)). Fixes undefined/element-web#6532.
* Hide screenshare button in video rooms on Desktop ([\element-hq#9045](matrix-org/matrix-react-sdk#9045)).
* Add a developer command to reset Megolm and Olm sessions ([\element-hq#9044](matrix-org/matrix-react-sdk#9044)).
* add spaces to TileErrorBoundary ([\element-hq#9012](matrix-org/matrix-react-sdk#9012)). Contributed by @HarHarLinks.
* Location sharing - add localised strings to map ([\element-hq#9025](matrix-org/matrix-react-sdk#9025)). Fixes element-hq#21443. Contributed by @kerryarchibald.
* Added trim to ignore whitespaces in email check ([\#9027](matrix-org/matrix-react-sdk#9027)). Contributed by @ankur12-1610.
* Improve _GenericEventListSummary.scss ([\element-hq#9005](matrix-org/matrix-react-sdk#9005)). Contributed by @luixxiul.
* Live location share - tiles without tile server (PSG-591) ([\element-hq#8962](matrix-org/matrix-react-sdk#8962)). Contributed by @kerryarchibald.
* Add option to display tooltip on link hover ([\element-hq#8394](matrix-org/matrix-react-sdk#8394)). Fixes element-hq#21907.
* Support a module API surface for custom functionality ([\element-hq#8246](matrix-org/matrix-react-sdk#8246)).
* Adjust encryption copy when creating a video room ([\element-hq#8989](matrix-org/matrix-react-sdk#8989)). Fixes element-hq#22737.
* Add bidirectonal isolation for pills ([\element-hq#8985](matrix-org/matrix-react-sdk#8985)). Contributed by @sha-265.
* Delabs `Show current avatar and name for users in message history` ([\element-hq#8764](matrix-org/matrix-react-sdk#8764)). Fixes element-hq#22336.
* Live location share - open latest location in map site ([\element-hq#8981](matrix-org/matrix-react-sdk#8981)). Contributed by @kerryarchibald.
* Improve LinkPreviewWidget ([\element-hq#8881](matrix-org/matrix-react-sdk#8881)). Fixes element-hq#22634. Contributed by @luixxiul.
* Render HTML topics in rooms on space home ([\element-hq#8939](matrix-org/matrix-react-sdk#8939)).
* Hide timestamp on event tiles being edited on every layout ([\element-hq#8956](matrix-org/matrix-react-sdk#8956)). Contributed by @luixxiul.
* Introduce new copy icon ([\element-hq#8942](matrix-org/matrix-react-sdk#8942)).
* Allow finding group DMs by members in spotlight ([\element-hq#8922](matrix-org/matrix-react-sdk#8922)). Fixes element-hq#22564. Contributed by @justjanne.
* Live location share - explicitly stop beacons replaced beacons ([\element-hq#8933](matrix-org/matrix-react-sdk#8933)). Contributed by @kerryarchibald.
* Remove unpin from widget kebab menu ([\element-hq#8924](matrix-org/matrix-react-sdk#8924)).
* Live location share - redact related locations on beacon redaction ([\element-hq#8926](matrix-org/matrix-react-sdk#8926)). Contributed by @kerryarchibald.
* Live location share - disallow message pinning ([\element-hq#8928](matrix-org/matrix-react-sdk#8928)). Contributed by @kerryarchibald.
* Remove the ability to hide yourself in video rooms ([\element-hq#22806](element-hq#22806)). Fixes element-hq#22805.
* Unbreak in-app permalink tooltips  ([\element-hq#9100](matrix-org/matrix-react-sdk#9100)).
* Add space for the stroke on message editor on IRC layout ([\element-hq#9030](matrix-org/matrix-react-sdk#9030)). Fixes element-hq#22785. Contributed by @luixxiul.
* Fix pinned messages not re-linkifying on edit ([\element-hq#9042](matrix-org/matrix-react-sdk#9042)). Fixes element-hq#22726.
* Don't unnecessarily persist the host signup dialog ([\element-hq#9043](matrix-org/matrix-react-sdk#9043)). Fixes element-hq#22778.
* Fix URL previews causing messages to become unrenderable ([\element-hq#9028](matrix-org/matrix-react-sdk#9028)). Fixes element-hq#22766.
* Fix event list summaries including invalid events ([\element-hq#9041](matrix-org/matrix-react-sdk#9041)). Fixes element-hq#22790.
* Correct accessibility labels for unread rooms in spotlight ([\element-hq#9003](matrix-org/matrix-react-sdk#9003)). Contributed by @justjanne.
* Enable search strings highlight on bubble layout ([\element-hq#9032](matrix-org/matrix-react-sdk#9032)). Fixes element-hq#22786. Contributed by @luixxiul.
* Unbreak URL preview for formatted links with tooltips ([\element-hq#9022](matrix-org/matrix-react-sdk#9022)). Fixes element-hq#22764.
* Re-add margin to tiles based on EventTileBubble ([\element-hq#9015](matrix-org/matrix-react-sdk#9015)). Fixes element-hq#22772. Contributed by @luixxiul.
* Fix Shortcut prompt for Search showing in minimized Roomlist ([\element-hq#9014](matrix-org/matrix-react-sdk#9014)). Fixes element-hq#22739. Contributed by @justjanne.
* Fix avatar position on event info line for hidden events on a thread ([\element-hq#9019](matrix-org/matrix-react-sdk#9019)). Fixes element-hq#22777. Contributed by @luixxiul.
* Fix lost padding of event tile info line ([\element-hq#9009](matrix-org/matrix-react-sdk#9009)). Fixes element-hq#22754 and element-hq#22759. Contributed by @luixxiul.
* Align verification bubble with normal event tiles on IRC layout ([\element-hq#9001](matrix-org/matrix-react-sdk#9001)). Fixes element-hq#22758. Contributed by @luixxiul.
* Ensure timestamp on generic event list summary is not hidden from TimelineCard ([\element-hq#9000](matrix-org/matrix-react-sdk#9000)). Fixes element-hq#22755. Contributed by @luixxiul.
* Fix headings margin on security user settings tab ([\element-hq#8826](matrix-org/matrix-react-sdk#8826)). Contributed by @luixxiul.
* Fix timestamp position on file panel ([\element-hq#8976](matrix-org/matrix-react-sdk#8976)). Fixes element-hq#22718. Contributed by @luixxiul.
* Stop using :not() pseudo class for mx_GenericEventListSummary ([\element-hq#8944](matrix-org/matrix-react-sdk#8944)). Fixes element-hq#22602. Contributed by @luixxiul.
* Don't show the same user twice in Spotlight ([\element-hq#8978](matrix-org/matrix-react-sdk#8978)). Fixes element-hq#22697.
* Align the right edge of expand / collapse link buttons of generic event list summary in bubble layout with a variable ([\element-hq#8992](matrix-org/matrix-react-sdk#8992)). Fixes element-hq#22743. Contributed by @luixxiul.
* Display own avatars on search results panel in bubble layout ([\element-hq#8990](matrix-org/matrix-react-sdk#8990)). Contributed by @luixxiul.
* Fix text flow of thread summary content on threads list ([\element-hq#8991](matrix-org/matrix-react-sdk#8991)). Fixes element-hq#22738. Contributed by @luixxiul.
* Fix the size of the clickable area of images ([\element-hq#8987](matrix-org/matrix-react-sdk#8987)). Fixes element-hq#22282.
* Fix font size of MessageTimestamp on TimelineCard ([\element-hq#8950](matrix-org/matrix-react-sdk#8950)). Contributed by @luixxiul.
* Improve security room settings tab style rules ([\element-hq#8844](matrix-org/matrix-react-sdk#8844)). Fixes element-hq#22575. Contributed by @luixxiul.
* Align E2E icon and avatar of info tile in compact modern layout ([\element-hq#8965](matrix-org/matrix-react-sdk#8965)). Fixes element-hq#22652. Contributed by @luixxiul.
* Fix clickable area of general event list summary toggle ([\element-hq#8979](matrix-org/matrix-react-sdk#8979)). Fixes element-hq#22722. Contributed by @luixxiul.
* Fix resizing room topic ([\element-hq#8966](matrix-org/matrix-react-sdk#8966)). Fixes element-hq#22689.
* Dismiss the search dialogue when starting a DM ([\element-hq#8967](matrix-org/matrix-react-sdk#8967)). Fixes element-hq#22700.
* Fix "greyed out" text style inconsistency on search result panel ([\element-hq#8974](matrix-org/matrix-react-sdk#8974)). Contributed by @luixxiul.
* Add top padding to EventTilePreview loader ([\element-hq#8977](matrix-org/matrix-react-sdk#8977)). Fixes element-hq#22719. Contributed by @luixxiul.
* Fix read receipts group position on TimelineCard in compact modern/group layout ([\element-hq#8971](matrix-org/matrix-react-sdk#8971)). Fixes element-hq#22715. Contributed by @luixxiul.
* Fix calls on homeservers without the unstable thirdparty endpoints. ([\element-hq#8931](matrix-org/matrix-react-sdk#8931)). Fixes element-hq#21680. Contributed by @deepbluev7.
* Enable ReplyChain text to be expanded on IRC layout ([\element-hq#8959](matrix-org/matrix-react-sdk#8959)). Fixes element-hq#22709. Contributed by @luixxiul.
* Fix hidden timestamp on message edit history dialog ([\element-hq#8955](matrix-org/matrix-react-sdk#8955)). Fixes element-hq#22701. Contributed by @luixxiul.
* Enable ReplyChain text to be expanded on bubble layout ([\element-hq#8958](matrix-org/matrix-react-sdk#8958)). Fixes element-hq#22709. Contributed by @luixxiul.
* Fix expand/collapse state wrong in metaspaces ([\element-hq#8952](matrix-org/matrix-react-sdk#8952)). Fixes element-hq#22632.
* Location (live) share replies now provide a fallback content ([\element-hq#8949](matrix-org/matrix-react-sdk#8949)).
* Fix space settings not opening for script-created spaces ([\element-hq#8957](matrix-org/matrix-react-sdk#8957)). Fixes element-hq#22703.
* Respect `filename` field on `m.file` events ([\element-hq#8951](matrix-org/matrix-react-sdk#8951)).
* Fix PlatformSettingsHandler always returning true due to returning a Promise ([\element-hq#8954](matrix-org/matrix-react-sdk#8954)). Fixes element-hq#22616.
* Improve high-contrast support for spotlight ([\element-hq#8948](matrix-org/matrix-react-sdk#8948)). Fixes element-hq#22481. Contributed by @justjanne.
* Fix wrong assertions that all media events have a mimetype ([\element-hq#8946](matrix-org/matrix-react-sdk#8946)). Fixes matrix-org/element-web-rageshakes#13727.
* Make invite dialogue fixed height ([\element-hq#8934](matrix-org/matrix-react-sdk#8934)). Fixes element-hq#22659.
* Fix all megolm error reported as unknown ([\element-hq#8916](matrix-org/matrix-react-sdk#8916)).
* Remove line-height declarations from _ReplyTile.scss ([\element-hq#8932](matrix-org/matrix-react-sdk#8932)). Fixes element-hq#22687. Contributed by @luixxiul.
* Reduce video rooms log spam ([\element-hq#8913](matrix-org/matrix-react-sdk#8913)).
* Correct new search input’s rounded corners ([\element-hq#8921](matrix-org/matrix-react-sdk#8921)). Fixes element-hq#22576. Contributed by @justjanne.
* Align unread notification dot on threads list in compact modern=group layout ([\element-hq#8911](matrix-org/matrix-react-sdk#8911)). Fixes element-hq#22677. Contributed by @luixxiul.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this pull request Aug 1, 2022
@su-ex
Merge tag 'v3.49.0' into sc
602c09e 
* Hide screenshare button in video rooms on Desktop ([\matrix-org#9045](matrix-org#9045)).
* Add a developer command to reset Megolm and Olm sessions ([\matrix-org#9044](matrix-org#9044)).
* add spaces to TileErrorBoundary ([\matrix-org#9012](matrix-org#9012)). Contributed by @HarHarLinks.
* Location sharing - add localised strings to map ([\matrix-org#9025](matrix-org#9025)). Fixes element-hq/element-web#21443. Contributed by @kerryarchibald.
* Added trim to ignore whitespaces in email check ([\matrix-org#9027](matrix-org#9027)). Contributed by @ankur12-1610.
* Improve _GenericEventListSummary.scss ([\matrix-org#9005](matrix-org#9005)). Contributed by @luixxiul.
* Live location share - tiles without tile server (PSG-591) ([\matrix-org#8962](matrix-org#8962)). Contributed by @kerryarchibald.
* Add option to display tooltip on link hover ([\matrix-org#8394](matrix-org#8394)). Fixes element-hq/element-web#21907.
* Support a module API surface for custom functionality ([\matrix-org#8246](matrix-org#8246)).
* Adjust encryption copy when creating a video room ([\matrix-org#8989](matrix-org#8989)). Fixes element-hq/element-web#22737.
* Add bidirectonal isolation for pills ([\matrix-org#8985](matrix-org#8985)). Contributed by @sha-265.
* Delabs `Show current avatar and name for users in message history` ([\matrix-org#8764](matrix-org#8764)). Fixes element-hq/element-web#22336.
* Live location share - open latest location in map site ([\matrix-org#8981](matrix-org#8981)). Contributed by @kerryarchibald.
* Improve LinkPreviewWidget ([\matrix-org#8881](matrix-org#8881)). Fixes element-hq/element-web#22634. Contributed by @luixxiul.
* Render HTML topics in rooms on space home ([\matrix-org#8939](matrix-org#8939)).
* Hide timestamp on event tiles being edited on every layout ([\matrix-org#8956](matrix-org#8956)). Contributed by @luixxiul.
* Introduce new copy icon ([\matrix-org#8942](matrix-org#8942)).
* Allow finding group DMs by members in spotlight ([\matrix-org#8922](matrix-org#8922)). Fixes element-hq/element-web#22564. Contributed by @justjanne.
* Live location share - explicitly stop beacons replaced beacons ([\matrix-org#8933](matrix-org#8933)). Contributed by @kerryarchibald.
* Remove unpin from widget kebab menu ([\matrix-org#8924](matrix-org#8924)).
* Live location share - redact related locations on beacon redaction ([\matrix-org#8926](matrix-org#8926)). Contributed by @kerryarchibald.
* Live location share - disallow message pinning ([\matrix-org#8928](matrix-org#8928)). Contributed by @kerryarchibald.
* Unbreak in-app permalink tooltips  ([\matrix-org#9100](matrix-org#9100)).
* Add space for the stroke on message editor on IRC layout ([\matrix-org#9030](matrix-org#9030)). Fixes element-hq/element-web#22785. Contributed by @luixxiul.
* Fix pinned messages not re-linkifying on edit ([\matrix-org#9042](matrix-org#9042)). Fixes element-hq/element-web#22726.
* Don't unnecessarily persist the host signup dialog ([\matrix-org#9043](matrix-org#9043)). Fixes element-hq/element-web#22778.
* Fix URL previews causing messages to become unrenderable ([\matrix-org#9028](matrix-org#9028)). Fixes element-hq/element-web#22766.
* Fix event list summaries including invalid events ([\matrix-org#9041](matrix-org#9041)). Fixes element-hq/element-web#22790.
* Correct accessibility labels for unread rooms in spotlight ([\matrix-org#9003](matrix-org#9003)). Contributed by @justjanne.
* Enable search strings highlight on bubble layout ([\matrix-org#9032](matrix-org#9032)). Fixes element-hq/element-web#22786. Contributed by @luixxiul.
* Unbreak URL preview for formatted links with tooltips ([\matrix-org#9022](matrix-org#9022)). Fixes element-hq/element-web#22764.
* Re-add margin to tiles based on EventTileBubble ([\matrix-org#9015](matrix-org#9015)). Fixes element-hq/element-web#22772. Contributed by @luixxiul.
* Fix Shortcut prompt for Search showing in minimized Roomlist ([\matrix-org#9014](matrix-org#9014)). Fixes element-hq/element-web#22739. Contributed by @justjanne.
* Fix avatar position on event info line for hidden events on a thread ([\matrix-org#9019](matrix-org#9019)). Fixes element-hq/element-web#22777. Contributed by @luixxiul.
* Fix lost padding of event tile info line ([\matrix-org#9009](matrix-org#9009)). Fixes element-hq/element-web#22754 and element-hq/element-web#22759. Contributed by @luixxiul.
* Align verification bubble with normal event tiles on IRC layout ([\matrix-org#9001](matrix-org#9001)). Fixes element-hq/element-web#22758. Contributed by @luixxiul.
* Ensure timestamp on generic event list summary is not hidden from TimelineCard ([\matrix-org#9000](matrix-org#9000)). Fixes element-hq/element-web#22755. Contributed by @luixxiul.
* Fix headings margin on security user settings tab ([\matrix-org#8826](matrix-org#8826)). Contributed by @luixxiul.
* Fix timestamp position on file panel ([\matrix-org#8976](matrix-org#8976)). Fixes element-hq/element-web#22718. Contributed by @luixxiul.
* Stop using :not() pseudo class for mx_GenericEventListSummary ([\matrix-org#8944](matrix-org#8944)). Fixes element-hq/element-web#22602. Contributed by @luixxiul.
* Don't show the same user twice in Spotlight ([\matrix-org#8978](matrix-org#8978)). Fixes element-hq/element-web#22697.
* Align the right edge of expand / collapse link buttons of generic event list summary in bubble layout with a variable ([\matrix-org#8992](matrix-org#8992)). Fixes element-hq/element-web#22743. Contributed by @luixxiul.
* Display own avatars on search results panel in bubble layout ([\matrix-org#8990](matrix-org#8990)). Contributed by @luixxiul.
* Fix text flow of thread summary content on threads list ([\matrix-org#8991](matrix-org#8991)). Fixes element-hq/element-web#22738. Contributed by @luixxiul.
* Fix the size of the clickable area of images ([\matrix-org#8987](matrix-org#8987)). Fixes element-hq/element-web#22282.
* Fix font size of MessageTimestamp on TimelineCard ([\matrix-org#8950](matrix-org#8950)). Contributed by @luixxiul.
* Improve security room settings tab style rules ([\matrix-org#8844](matrix-org#8844)). Fixes element-hq/element-web#22575. Contributed by @luixxiul.
* Align E2E icon and avatar of info tile in compact modern layout ([\matrix-org#8965](matrix-org#8965)). Fixes element-hq/element-web#22652. Contributed by @luixxiul.
* Fix clickable area of general event list summary toggle ([\matrix-org#8979](matrix-org#8979)). Fixes element-hq/element-web#22722. Contributed by @luixxiul.
* Fix resizing room topic ([\matrix-org#8966](matrix-org#8966)). Fixes element-hq/element-web#22689.
* Dismiss the search dialogue when starting a DM ([\matrix-org#8967](matrix-org#8967)). Fixes element-hq/element-web#22700.
* Fix "greyed out" text style inconsistency on search result panel ([\matrix-org#8974](matrix-org#8974)). Contributed by @luixxiul.
* Add top padding to EventTilePreview loader ([\matrix-org#8977](matrix-org#8977)). Fixes element-hq/element-web#22719. Contributed by @luixxiul.
* Fix read receipts group position on TimelineCard in compact modern/group layout ([\matrix-org#8971](matrix-org#8971)). Fixes element-hq/element-web#22715. Contributed by @luixxiul.
* Fix calls on homeservers without the unstable thirdparty endpoints. ([\matrix-org#8931](matrix-org#8931)). Fixes element-hq/element-web#21680. Contributed by @deepbluev7.
* Enable ReplyChain text to be expanded on IRC layout ([\matrix-org#8959](matrix-org#8959)). Fixes element-hq/element-web#22709. Contributed by @luixxiul.
* Fix hidden timestamp on message edit history dialog ([\matrix-org#8955](matrix-org#8955)). Fixes element-hq/element-web#22701. Contributed by @luixxiul.
* Enable ReplyChain text to be expanded on bubble layout ([\matrix-org#8958](matrix-org#8958)). Fixes element-hq/element-web#22709. Contributed by @luixxiul.
* Fix expand/collapse state wrong in metaspaces ([\matrix-org#8952](matrix-org#8952)). Fixes element-hq/element-web#22632.
* Location (live) share replies now provide a fallback content ([\matrix-org#8949](matrix-org#8949)).
* Fix space settings not opening for script-created spaces ([\matrix-org#8957](matrix-org#8957)). Fixes element-hq/element-web#22703.
* Respect `filename` field on `m.file` events ([\matrix-org#8951](matrix-org#8951)).
* Fix PlatformSettingsHandler always returning true due to returning a Promise ([\matrix-org#8954](matrix-org#8954)). Fixes element-hq/element-web#22616.
* Improve high-contrast support for spotlight ([\matrix-org#8948](matrix-org#8948)). Fixes element-hq/element-web#22481. Contributed by @justjanne.
* Fix wrong assertions that all media events have a mimetype ([\matrix-org#8946](matrix-org#8946)). Fixes matrix-org/element-web-rageshakes#13727.
* Make invite dialogue fixed height ([\matrix-org#8934](matrix-org#8934)). Fixes element-hq/element-web#22659.
* Fix all megolm error reported as unknown ([\matrix-org#8916](matrix-org#8916)).
* Remove line-height declarations from _ReplyTile.scss ([\matrix-org#8932](matrix-org#8932)). Fixes element-hq/element-web#22687. Contributed by @luixxiul.
* Reduce video rooms log spam ([\matrix-org#8913](matrix-org#8913)).
* Correct new search input’s rounded corners ([\matrix-org#8921](matrix-org#8921)). Fixes element-hq/element-web#22576. Contributed by @justjanne.
* Align unread notification dot on threads list in compact modern=group layout ([\matrix-org#8911](matrix-org#8911)). Fixes element-hq/element-web#22677. Contributed by @luixxiul.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@turt2live turt2live turt2live approved these changes

@janogarcia janogarcia janogarcia approved these changes

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show the target of a link, when you hover over it.
6 participants
@Johennes @janogarcia @turt2live @t3chguy @MadLittleMods @robintown